Process GC preserve #156
Merged
Process GC preserve #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qinsoon
reviewed
Jun 12, 2024
mmtk/src/julia_scanning.rs
Outdated
| ) { | ||
| // process transitively pinning stack first | ||
| let pinning_closure = if let Some(c) = pclosure { |
There was a problem hiding this comment.
I would suggest having a separate method mmtk_scan_tpin_gcstack or something, and deal with the new stack there. The current code is too confusing: the tpin_gcstack is scanned with the normal closure when pclosure has a value. Creating a new function to scan tpin_gcstack and only pass the closure that is needed to the new function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Processing GC preserve regions.
Note that objects in these regions are currently put into a separate stack (
tpin_gcstack), but later on, when we lower the code for pushing and popping objects into LLVM, we might be able to reuse thegcstackand create a separate frame that we can push and pop. We cannot currently do that because we are currently pushing and popping outside of the current function, using the hook functions.